Update test_nnunetv2runner#7483
Conversation
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
|
The change nnUNet that this fixes appears to be in version 2.2, we should specify somewhere that this version is needed now. I don't see where we've specified nnUNet as a dependency however. |
|
Hi @ericspod, we didn't add nnunetv2 as a dependency requirement, the error log is from daily ci in the blossom which fixed the nnunetv2 version to 2.1 as a workaround, but due to the recent update from nnunet team, It raises another error, so I update the nnUNetV2Runner to be compatible with the latest nnunet. Do you think if we need to mention the version in docstring or somewhere else? |
We don't mention the requirements for any of the things in the |
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
|
Mentioned it in the docstring for now. |
|
/build |
Fixes Project-MONAI#7013 Project-MONAI#7478 ### Description replace `predict_from_raw_data` with `nnUNetPredictor` in test_nnunetv2runner ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Signed-off-by: Juan Pablo de la Cruz Gutiérrez <juampatronics@gmail.com>
Fixes Project-MONAI#7013 Project-MONAI#7478 ### Description replace `predict_from_raw_data` with `nnUNetPredictor` in test_nnunetv2runner ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Signed-off-by: Yu0610 <612410030@alum.ccu.edu.tw>
Fixes #7013 #7478
Description
replace
predict_from_raw_datawithnnUNetPredictorin test_nnunetv2runnerTypes of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.