-
Notifications
You must be signed in to change notification settings - Fork 91
337 Add config tests #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yiheng-wang-nv
merged 45 commits into
Project-MONAI:dev
from
yiheng-wang-nv:add-config-tests
Jun 2, 2023
Merged
337 Add config tests #400
yiheng-wang-nv
merged 45 commits into
Project-MONAI:dev
from
yiheng-wang-nv:add-config-tests
Jun 2, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Collaborator
Author
|
/build |
Signed-off-by: Yiheng Wang <[email protected]>
Collaborator
Author
|
/build |
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
for more information, see https://pre-commit.ci
Collaborator
Author
|
/build |
Signed-off-by: Yiheng Wang <[email protected]>
…o into add-config-tests
Collaborator
Author
|
/build |
Collaborator
Author
|
todo: all test on evaluation, mgpu train, mgpu evaluation, inference, determinism train. |
Collaborator
Author
|
/build |
Signed-off-by: Yiheng Wang <[email protected]>
yiheng-wang-nv
commented
May 6, 2023
Collaborator
Author
|
/build |
Nic-Ma
reviewed
May 6, 2023
Collaborator
This was referenced May 15, 2023
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Collaborator
|
/build |
1 similar comment
Collaborator
|
/build |
Signed-off-by: Yiheng Wang <[email protected]>
Collaborator
Author
|
/build |
9 similar comments
Collaborator
|
/build |
Collaborator
|
/build |
Collaborator
|
/build |
Collaborator
|
/build |
Collaborator
|
/build |
Collaborator
|
/build |
Collaborator
Author
|
/build |
Collaborator
|
/build |
Collaborator
Author
|
/build |
d850f92 to
d52af36
Compare
Signed-off-by: Yiheng Wang <[email protected]>
Collaborator
Author
|
/build |
Signed-off-by: Yiheng Wang <[email protected]>
Collaborator
Author
|
/build |
Collaborator
|
/build |
1 similar comment
Collaborator
|
/build |
Collaborator
|
/build |
Signed-off-by: Yiheng Wang <[email protected]>
Collaborator
Author
|
/build |
Nic-Ma
approved these changes
Jun 2, 2023
yiheng-wang-nv
added a commit
to yiheng-wang-nv/model-zoo
that referenced
this pull request
Jul 29, 2024
Fixes Project-MONAI#337 . ### Description This PR adds unit tests scripts, as well as test files on brats segmentation and spleen ct segmentation bundles. Tests are for both single GPU and multiple GPUs. In addition, the PR also enhances the current Blossom CI pipelines. For PRs that do not need to use GPU or multiple GPUs, the pipeline will not wait for resources first. ### Status **Ready** ### Please ensure all the checkboxes: <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Codeformat tests passed locally by running `./runtests.sh --codeformat`. - [ ] In-line docstrings updated. - [ ] Update `version` and `changelog` in `metadata.json` if changing an existing bundle. - [ ] Please ensure the naming rules in config files meet our requirements (please refer to: `CONTRIBUTING.md`). - [ ] Ensure versions of packages such as `monai`, `pytorch` and `numpy` are correct in `metadata.json`. - [ ] Descriptions should be consistent with the content, such as `eval_metrics` of the provided weights and TorchScript modules. - [ ] Files larger than 25MB are excluded and replaced by providing download links in `large_file.yml`. - [ ] Avoid using path that contains personal information within config files (such as use `/home/your_name/` for `"bundle_root"`). --------- Signed-off-by: Yiheng Wang <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #337 .
Description
This PR adds unit tests scripts, as well as test files on brats segmentation and spleen ct segmentation bundles. Tests are for both single GPU and multiple GPUs.
In addition, the PR also enhances the current Blossom CI pipelines. For PRs that do not need to use GPU or multiple GPUs, the pipeline will not wait for resources first.
Status
Ready
Please ensure all the checkboxes:
./runtests.sh --codeformat.versionandchangeloginmetadata.jsonif changing an existing bundle.CONTRIBUTING.md).monai,pytorchandnumpyare correct inmetadata.json.eval_metricsof the provided weights and TorchScript modules.large_file.yml./home/your_name/for"bundle_root").