Skip to content

Conversation

@danpat
Copy link
Member

@danpat danpat commented May 19, 2016

At Mapbox, we primarily use OSRM via the node-osrm bindings. These currently live in a separate project, but are tagged and released in lockstep with osrm-backend.

This PR brings the node-osrm codebase into osrm-backend, and builds it at the same time as the rest of the code. This should reduce the friction we experience internally when needing to make osrm-backend features quickly available for NodeJS-based projects for folks not familiar with building C++ projects.

The only extra tools required are CMake 3.1, and npm install node-cmake.

TODO:

  • make it compile and link against the current build (DONE: cmake -DNODEJS=ON .., off by default)
  • import test suite and make it work (DONE: npm run node-test)
  • enable static linking of dependencies for hassle-free npm install support on various platforms
  • support easy publishing of binaries/build-from-source support (via Support for alternative build tools (node-cmake) mapbox/node-pre-gyp#205)
  • CMake 3.1 will be required - update Travis build and dependency documentation.

@TheMarex please don't hate me.

@daniel-j-h
Copy link
Member

Even Ubuntu 14.04 (LTS) does not ship with CMake 3.1+, so it's pretty bad wrt. building only osrm-backend or libosrm on different distributions. Could we at least decouple the root CMakeLists.txt from the Node.js binding's one only having the latter require CMake 3.1?

@danpat
Copy link
Member Author

danpat commented May 19, 2016

@daniel-j-h yeah, that's not a bad idea. Our node-osrm Travis build already pulls down cmake 3.2.x, so I'm OK requiring folks to get a newer cmake to get Node stuff.

danpat and others added 3 commits May 19, 2016 13:22
 - osrm-backend moved to monoco, let's stay on berlin to avoid needing to update node-osrm tests

This reverts commit 8ab75b7.
@TheMarex TheMarex added this to the 6.0 milestone May 23, 2016
@MoKob MoKob changed the title [WIP] Bring node-osrm bindings into main project Bring node-osrm bindings into main project Sep 2, 2016
@TheMarex TheMarex mentioned this pull request Oct 26, 2016
3 tasks
@TheMarex
Copy link
Member

Closing in favor of tracking in an issue since the code here is stale anyway. #3183

@TheMarex TheMarex closed this Oct 26, 2016
@daniel-j-h daniel-j-h deleted the node_osrm branch February 22, 2017 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants