Bring node-osrm bindings into main project #2420
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At Mapbox, we primarily use OSRM via the
node-osrmbindings. These currently live in a separate project, but are tagged and released in lockstep withosrm-backend.This PR brings the
node-osrmcodebase intoosrm-backend, and builds it at the same time as the rest of the code. This should reduce the friction we experience internally when needing to makeosrm-backendfeatures quickly available for NodeJS-based projects for folks not familiar with building C++ projects.The only extra tools required are CMake 3.1, and
npm install node-cmake.TODO:
cmake -DNODEJS=ON .., off by default)npm run node-test)npm installsupport on various platforms@TheMarex please don't hate me.