Add missed constraints for reduced value，ins/ext instructions，and initial next pc#198
Merged
eigmax merged 7 commits intoProjectZKM:mainfrom May 29, 2025
Merged
Add missed constraints for reduced value，ins/ext instructions，and initial next pc#198eigmax merged 7 commits intoProjectZKM:mainfrom
eigmax merged 7 commits intoProjectZKM:mainfrom
Conversation
add constraits for the initial next_pc
eigmax
approved these changes
May 28, 2025
eigmax
reviewed
May 28, 2025
| cols.next_next_pc = Word::from(event.next_next_pc); | ||
| cols.next_pc_range_checker.populate(event.next_pc); | ||
| cols.target_pc_range_checker.populate(target_pc); | ||
| cols.next_next_pc_range_checker.populate(event.next_next_pc); |
Member
There was a problem hiding this comment.
Is it necessary to range check the target_pc?
Contributor
Author
There was a problem hiding this comment.
next_next_pc will be target pc when branching. target pc will be unused when not branching. So I think check on next_next_pc can replace check on target pc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.