Conversation
* feat: prevent read/write registers by memory instructions * fix memory prgram * bump 1.2.3 * fix comments
* add comments for biguint_to_field to note that it will convert a BigUint into a field element regardless of its size * fix inconsistent or outdated documentation * fix other maintainability concerns * fix clippy
* Update hash.rs * Update lib.rs * Update public_values.rs
* add aligned check for memory instructions * improve c_eq_0 check for mov_cond
* fix typos * Update mod.rs * fix
* fix syswrite panic when receive invalid utf-8 data * fix panic problem for divide-0 and teq * fix index panic problem for commit syscall * fix overflowing arithmetic in madd/sub and sysmap * add bound check for load/store instruction to fix panic for out of bound memory access * update return type for syscall.execute * add bound check for commit syscalls * fix panic problem for verify * fix panic problem for hint * remove movcond import in misc/others
felicityin
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix audit issues.