fix(zkvm): remove dead hash_input allocation in verify syscall#395
Merged
eigmax merged 1 commit intoProjectZKM:mainfrom Dec 30, 2025
Merged
fix(zkvm): remove dead hash_input allocation in verify syscall#395eigmax merged 1 commit intoProjectZKM:mainfrom
eigmax merged 1 commit intoProjectZKM:mainfrom
Conversation
eigmax
pushed a commit
that referenced
this pull request
Jan 4, 2026
* fix: correct stateless prove_core doc reference (#392) * fix(sdk): remove unnecessary clone in zkm_dump (#393) * fix(zkvm): remove dead hash_input allocation in verify syscall (#395) * docs: clarify Shape::new constructor comment (#394) * docs: correct septic curve documentation comments (#396) * fix: avoid extra allocation in ZKMPublicValues::raw --------- Co-authored-by: ANtutov <tutovanton26@gmail.com> Co-authored-by: Snezhkko <snezhkodaria38@gmail.com> Co-authored-by: yyhrnk <yaroslavnerest@gmail.com> Co-authored-by: sashass1315 <sashass1315@gmail.com> Co-authored-by: VolodymyrBg <aqdrgg19@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The verify syscall was creating a local Vec named hash_input, filling it with the previous deferred proofs digest, and then never using it. The actual deferred proofs digest is updated exclusively via hash_deferred_proof, which already reconstructs the full Poseidon2 input internally. Keeping hash_input introduces an unnecessary heap allocation and a misleading hint that the Vec participates in the hash chain. This change removes the dead Vec and leaves the digest update logic solely in hash_deferred_proof, matching how the prover side computes the deferred proofs digest.