Skip to content

Comments

Emit armor headers in sorted order#255

Merged
twiss merged 1 commit intoProtonMail:mainfrom
pgpkeys-eu:issue-254
Dec 3, 2024
Merged

Emit armor headers in sorted order#255
twiss merged 1 commit intoProtonMail:mainfrom
pgpkeys-eu:issue-254

Conversation

@andrewgdotcom
Copy link
Contributor

closes #254

Copy link
Member

@lubux lubux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

@twiss
Copy link
Collaborator

twiss commented Dec 3, 2024

For completeness, in case this is something you care about, note that key serialization for entities with multiple user IDs is also not deterministic:

for _, ident := range e.Identities {
(and the same applies in SerializePrivate).

@andrewgdotcom
Copy link
Contributor Author

key serialization for entities with multiple user IDs is also not deterministic:

We don't call that code in hockeypuck AFAICT. We have a standard sort order that gets applied to packet sequences before display in the index view, which we can also apply to armored output.

@twiss twiss merged commit b01f065 into ProtonMail:main Dec 3, 2024
@andrewgdotcom andrewgdotcom deleted the issue-254 branch December 3, 2024 11:09
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request Jan 8, 2025
…499)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/ProtonMail/go-crypto](https://github.com/ProtonMail/go-crypto) | require | patch | `v1.1.3` -> `v1.1.4` |

---

### Release Notes

<details>
<summary>ProtonMail/go-crypto (github.com/ProtonMail/go-crypto)</summary>

### [`v1.1.4`](https://github.com/ProtonMail/go-crypto/releases/tag/v1.1.4)

[Compare Source](ProtonMail/go-crypto@v1.1.3...v1.1.4)

#### What's Changed

-   Emit armor headers in sorted order by [@&#8203;andrewgdotcom](https://github.com/andrewgdotcom) in ProtonMail/go-crypto#255
-   Reduce memory usage when AEAD en/decrypting large messages by [@&#8203;twiss](https://github.com/twiss) in ProtonMail/go-crypto#259
-   Update artifact actions to v4 by [@&#8203;twiss](https://github.com/twiss) in ProtonMail/go-crypto#260

**Full Changelog**: ProtonMail/go-crypto@v1.1.3...v1.1.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "* 0-3 * * *" (UTC), Automerge - "* 0-3 * * *" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45Mi4wIiwidXBkYXRlZEluVmVyIjoiMzkuOTIuMCIsInRhcmdldEJyYW5jaCI6ImZvcmdlam8iLCJsYWJlbHMiOlsiZGVwZW5kZW5jeS11cGdyYWRlIiwidGVzdC9ub3QtbmVlZGVkIl19-->

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6499
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Emit armor headers in sorted order

3 participants