Skip to content

Comments

Make Issuer Key ID signature subpacket non-critical#266

Merged
twiss merged 1 commit intoProtonMail:mainfrom
caarlos0:issuer-key-id
Feb 27, 2025
Merged

Make Issuer Key ID signature subpacket non-critical#266
twiss merged 1 commit intoProtonMail:mainfrom
caarlos0:issuer-key-id

Conversation

@caarlos0
Copy link
Contributor

closes #263

@twiss twiss changed the title fix: make issuerKeyID non-critical again Make Issuer Key ID signature subpacket non-critical Feb 26, 2025
@twiss twiss merged commit d47bb38 into ProtonMail:main Feb 27, 2025
10 checks passed
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request Feb 28, 2025
…068)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/ProtonMail/go-crypto](https://github.com/ProtonMail/go-crypto) | require | patch | `v1.1.5` -> `v1.1.6` |

---

### Release Notes

<details>
<summary>ProtonMail/go-crypto (github.com/ProtonMail/go-crypto)</summary>

### [`v1.1.6`](https://github.com/ProtonMail/go-crypto/releases/tag/v1.1.6)

[Compare Source](ProtonMail/go-crypto@v1.1.5...v1.1.6)

#### What's Changed

-   Fix `PublicKey.KeyIdString` to return a valid key id by [@&#8203;lubux](https://github.com/lubux) in ProtonMail/go-crypto#269
-   Allow Key Flags override [@&#8203;davrux](https://github.com/davrux) in ProtonMail/go-crypto#272
-   Only check that message signatures are newer than the key by [@&#8203;twiss](https://github.com/twiss) in ProtonMail/go-crypto#275
-   openpgp/clearsign: just use rand.Reader in tests by [@&#8203;mdosch](https://github.com/mdosch) in ProtonMail/go-crypto#276
-   Make Issuer Key ID signature subpacket non-critical by [@&#8203;caarlos0](https://github.com/caarlos0) in ProtonMail/go-crypto#266
-   v2 API: Improve error messages for encryption key selection by [@&#8203;lubux](https://github.com/lubux) in ProtonMail/go-crypto#271

**Full Changelog**: ProtonMail/go-crypto@v1.1.5...v1.1.6

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "* 0-3 * * *" (UTC), Automerge - "* 0-3 * * *" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNzguMSIsInVwZGF0ZWRJblZlciI6IjM5LjE3OC4xIiwidGFyZ2V0QnJhbmNoIjoiZm9yZ2VqbyIsImxhYmVscyI6WyJkZXBlbmRlbmN5LXVwZ3JhZGUiLCJ0ZXN0L25vdC1uZWVkZWQiXX0=-->

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7068
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IssuerKeyId criticality and unsupported implementations

2 participants