Closed
Conversation
added 7 commits
August 28, 2019 11:57
… read.go, write.go
twiss
reviewed
Aug 29, 2019
| } | ||
|
|
||
| if ek.KeyId != keyId || ek.Algo != PubKeyAlgoRSA { | ||
| if ek.KeyId != keyID || ek.Algo != PubKeyAlgoRSA { |
Collaborator
There was a problem hiding this comment.
Since we have to export KeyId, I think having keyID is kinda inconsistent. I'm not sure that it's worth appeasing the linter for that
| p = new(LiteralData) | ||
| case packetTypeUserId: | ||
| case packetTypeUserID: | ||
| p = new(UserId) |
Collaborator
There was a problem hiding this comment.
Similarly here (UserId / UserID). We might just want to keep Id everywhere, linter be damned
| } | ||
|
|
||
| // ArmorCorrupt is returned if an armor is invalid. | ||
| var ArmorCorrupt error = errors.StructuralError("armor invalid") |
Collaborator
There was a problem hiding this comment.
I know the linter says to add comments to every exported symbol, but some of these are completely self-explanatory even from the name - so then the comment naturally feels kinda redundant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed in favor of 32
Covers openpgp go package only
This branch contains a linted OpenPGP package (
crypto/openpgp) withgolint, vet, errcheck, deadcode, etc. More precisely, using this plugin and invokingGoMetaLinter.Notes:
Exported functions, variables, methods, properties, are not corrected in order to preserve the API. Redundant error checking in
_testfiles is ignored as well.