Fix settings labels on small devices#2421
Merged
JoeMatt merged 2 commits intoProvenance-Emu:developfrom Aug 29, 2025
dnicolson:patch-2
Merged
Fix settings labels on small devices#2421JoeMatt merged 2 commits intoProvenance-Emu:developfrom dnicolson:patch-2
JoeMatt merged 2 commits intoProvenance-Emu:developfrom
dnicolson:patch-2
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
JoeMatt
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
What does this PR do
Makes the settings labels left-aligned. This means on smaller devices, it is consistent with the toggle cells.
Where should the reviewer start
How should this be manually tested
Any background context you want to provide
What are the relevant tickets
Screenshots (important for UI changes)
|
Questions
PR Type
Bug fix
Description
Fix text alignment for settings labels on small devices
Add leading text alignment for subtitle text
Minor punctuation corrections in subtitle text
Diagram Walkthrough
File Walkthrough
SettingsSwiftUI.swift
Fix subtitle text alignment and punctuationPVUI/Sources/PVSwiftUI/Settings/SettingsSwiftUI.swift
.multilineTextAlignment(.leading)to subtitle text for leftalignment
subtitles