Skip to content

Fix search bar position#2430

Merged
JoeMatt merged 1 commit intoProvenance-Emu:developfrom
dnicolson:patch-4
Oct 21, 2025
Merged

Fix search bar position#2430
JoeMatt merged 1 commit intoProvenance-Emu:developfrom
dnicolson:patch-4

Conversation

@dnicolson
Copy link
Contributor

@dnicolson dnicolson commented Oct 20, 2025

User description

What does this PR do

Fixes the menu bar position after interacting with the search field, preventing it from covering the "Settings" item.

Where should the reviewer start

How should this be manually tested

Any background context you want to provide

What are the relevant tickets

Screenshots (important for UI changes)

B7B33991-C978-484D-958E-744D900D8C33_1_102_o

Questions


PR Type

Bug fix


Description

  • Prevents navigation bar from hiding during search presentation

  • Fixes menu bar covering "Settings" item after search interaction


Diagram Walkthrough

flowchart LR
  A["Search Controller"] -- "hidesNavigationBarDuringPresentation = false" --> B["Navigation Bar Stays Visible"]
  B --> C["Menu Items Remain Accessible"]
Loading

File Walkthrough

Relevant files
Bug fix
SearchBar.swift
Disable navigation bar hiding during search                           

PVUI/Sources/PVUIBase/SwiftUI/Components/SearchBar.swift

  • Added hidesNavigationBarDuringPresentation = false to search
    controller configuration
  • Prevents navigation bar from being hidden when search is active
  • Ensures menu items like "Settings" remain visible and accessible
+1/-0     

@qodo-code-review
Copy link

qodo-code-review bot commented Oct 20, 2025

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
- [ ] Create ticket/issue <!-- /create_ticket --create_ticket=true -->

</details></td></tr>
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
No custom compliance provided

Follow the guide to enable custom compliance check.

  • Update
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-code-review
Copy link

qodo-code-review bot commented Oct 20, 2025

PR Code Suggestions ✨

No code suggestions found for the PR.

@JoeMatt JoeMatt merged commit c09cab1 into Provenance-Emu:develop Oct 21, 2025
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants