Fix search bar position#2430
Merged
JoeMatt merged 1 commit intoProvenance-Emu:developfrom Oct 21, 2025
dnicolson:patch-4
Merged
Fix search bar position#2430JoeMatt merged 1 commit intoProvenance-Emu:developfrom dnicolson:patch-4
JoeMatt merged 1 commit intoProvenance-Emu:developfrom
dnicolson:patch-4
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
What does this PR do
Fixes the menu bar position after interacting with the search field, preventing it from covering the "Settings" item.
Where should the reviewer start
How should this be manually tested
Any background context you want to provide
What are the relevant tickets
Screenshots (important for UI changes)
Questions
PR Type
Bug fix
Description
Prevents navigation bar from hiding during search presentation
Fixes menu bar covering "Settings" item after search interaction
Diagram Walkthrough
File Walkthrough
SearchBar.swift
Disable navigation bar hiding during searchPVUI/Sources/PVUIBase/SwiftUI/Components/SearchBar.swift
hidesNavigationBarDuringPresentation = falseto searchcontroller configuration