Bump metrics-exporter-prometheus version to 0.17#84
Bump metrics-exporter-prometheus version to 0.17#84Ptrskay3 merged 2 commits intoPtrskay3:masterfrom raimannma:master
Conversation
|
Thanks! Can you explain the motivation behind the change? Why is this an improvement? |
|
Sure. The most important update is the metrics-exporter-prometheus update, as they updated their dependencies too. For the other crates, I remove the specification of the minor and patch versions. This enables Cargo to select the best version overall for a project's dependencies. Otherwise, Cargo needs to create a duplicate dependency. Other possible ways:
PS: Old version of metrics-exporter-prometheus had |
|
Well, as far as I can see the only justified thing here is the update of |
|
Alright, I changed it to just update the versions, without removing anything from the version string. |
|
CI should run successfully now, checked in my fork: https://github.com/raimannma/axum-prometheus/actions/runs/15606103803 |
|
Hey @Ptrskay3 I changed the PR to be a minimal change only, just updating metrics-exporter-prometheus. PS: The CI will fail, as there are bugs in the examples. |
|
Can you fix the examples, or should I? (I don't really understand why did you revert it though, you already fixed them at some point, no?) |
|
Yeah I have the commit in my fork. Can open another PR, just thought that fixing the examples should not be in this PR as it has nothing to do with the version upgrade. |
|
The examples are broken due to the version upgrade as far as I can see (I haven't checked out your branch locally, correct me if I'm wrong), so we should fix them here I guess. |
|
Thanks! |
This pull request updates the dependency versions in the
Cargo.tomlfile to simplify versioning.