Merged
Conversation
Owner
|
Thanks, looks good from first glance. I'll probably have to time review it properly this weekend. |
Ptrskay3
reviewed
Jun 30, 2025
Owner
Ptrskay3
left a comment
There was a problem hiding this comment.
Just a nit, but looks good. Thanks!
Do you want to add this to the changelog as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal to resolve the following issue:
This is my first contribution, please let me know if there's anything I can do 🙏
I tested on a small project like this:
With the following calls:
#!/bin/sh curl localhost:8000/hello curl localhost:8000/hello curl localhost:8000/hello curl localhost:8000/hola curl localhost:8000/hola curl localhost:8000/hi curl localhost:8000/hi/hi curl localhost:8000/hi/tomato curl localhost:8000/.aws/credentials curl localhost:8000/.aws/credentials curl localhost:8000/.aws/credentials curl localhost:8000/sqdokqsdk curl localhost:8000/:sqdqsd curl localhost:8000/azertyI've got those metrics:
