Change from valueCode to parentCode as keys

[JohannesFinsveen]

Does children have parents or does parents have children :-)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[likp]

This PR make sens, I did not dare to change the code to much.

Since we are tidying up the code it what is the purpose of GetValueGroupRowsByParentCode It seams to just do a shallow copy of the same Dictonary that it get from GetValueGroupRowsByParentCodeFromBucket

[JohannesFinsveen]

Doesnt it split unlikely long lists of parentCodes(500, hardcoded :-) ) into chunks(buckets), loop the chunks and glue the result together... But could the dict be (string , List) ? Meeting tomorrow?

[likp]

You are right I missed the call to CreateGroupCodeBuckets.

We have holiday tomorrow, Midsommar. But I think it looks good. I will approved it shortly.

[likp]

LGTM

[JohannesFinsveen]

We have holiday tomorrow, Midsommar.

But St. Hans is on monday :-) Enjoy!