FunctionType typing improvements #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, represent FunctionType as an enum.Enum. This is more about the data type's concept than any actual high-level features. Then use FunctionType so improve the typing of various dictionaries and function signatures. Lastly, use setattr() for our AST monkey patching. I tried a few other approaches here (using ast.(Async)FunctionDef subclasses, introducing a new protocol, etc.), but the monkey patching approach always came out the simplest and most obvious. Using setattr() avoids typing errors related to unknown direct attribute assignments.
sigmavirus24
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, represent FunctionType as an enum.Enum. This is more about the data type's concept than any higher-level Enum features.
Then use FunctionType so improve the typing of various dictionaries and function signatures.
Lastly, use setattr() for our AST monkey patching. I tried a few other approaches here (using ast.(Async)FunctionDef subclasses, introducing a new protocol, etc.), but the monkey patching approach always came out the simplest and most obvious. Using setattr() avoids typing errors related to unknown direct attribute assignments.