This repository was archived by the owner on Nov 3, 2023. It is now read-only.
Fix match option to only consider basename when given a path argument#550
Merged
sambhav merged 5 commits intoPyCQA:masterfrom Dec 30, 2021
Merged
Fix match option to only consider basename when given a path argument#550sambhav merged 5 commits intoPyCQA:masterfrom
sambhav merged 5 commits intoPyCQA:masterfrom
Conversation
sambhav
approved these changes
Dec 30, 2021
Member
|
@oczkoisse 👋 Thank you so much for the fix and sorry for the delay in reviewing the PR. After my latest commit I am in a difficult conundrum with this since one way breaks b/w compat for nested match paths and the other causes issues with negative match directives. Re-thinking this PR in the context of #529 - I think it might be better for me to revert my latest commit and merge #529 to have proper support for nested dir paths. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #549.
This uses
os.path.basenamebefore trying to match against the pattern set in--matchoption. This way, even if full paths to files are passed topydocstyle(by VSCode, for example), only filename part of the path will be matched with the set pattern, thereby eliminating accidental matches with the path. This is also more consistent with how--matchis documented previously.Please make sure to check for the following items:
If you've added an error code or changed an error code behavior,
you should probably add or change a test case file under
tests/test_cases/and addit to the list under
tests/test_definitions.py.If you've added or changed a command line option,
you should probably add or change a test in
tests/test_integration.py.Make sure to include the PR number after you open and get one.