This repository was archived by the owner on Nov 3, 2023. It is now read-only.
Open
Conversation
Author
|
I noticed a strange side effect. When using the changes of this PR, D105 is never detected. |
Author
|
Should be fixed now. I missed that the evaluation of the error |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #525 and also the
def __init__()overloading which is not explicitly part of that issue.The fix simply makes use of the existing
is_overloadproperty also in the case thatdefinition.is_magicis true. Previously, this was somehow missed in the inlined if-else construct. I expanded that part to more explicit statements and used a new variable.I also tried #555 and at least added a match for "typing.overload". But I don't know if pydocstyle is able to infer if a decorator is actually a name bound at import by something like:
from typing import overload as my_overload.If not, then I don't see a way to "know" if a given decorator is a
typing.overload.If this is ok, I'd add tests as well.
TODO:
Make sure to include the PR number after you open and get one.