This repository was archived by the owner on Nov 3, 2023. It is now read-only.
Allow to run with all Python optimizations enabled#607
Draft
mondeja wants to merge 2 commits intoPyCQA:masterfrom
Draft
Allow to run with all Python optimizations enabled#607mondeja wants to merge 2 commits intoPyCQA:masterfrom
mondeja wants to merge 2 commits intoPyCQA:masterfrom
Conversation
Member
|
I'm not speaking as a maintainer here but I don't think this is desirable in the slightest. Using the docstrings for explaining the error is maybe questionable but just removing the docstrings altogether is a big mistake and hurts maintainability and readability of this tool |
Author
|
I'm open to duplicate the explanations to avoid the docstrings stripping and add a test to synchronize docstrings with explanations. If a maintainer can take a final decission I'll be happy to implement it 👍🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #606