-
Notifications
You must be signed in to change notification settings - Fork 69
fix: Allow COPT solution parsing for IMPRECISE status #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add 'numerical' and 'imprecise' as proper TerminationCondition enum values and map them to SolverStatus.ok to enable solution extraction for both COPT solver statuses. This fixes issue #460 where COPT solutions with IMPRECISE status were not being parsed, even though COPT developers confirmed solutions should be available for OK, NUMERICAL, and IMPRECISE statuses. Co-authored-by: Fabian Hofmann <[email protected]>
|
Claude finished @FabianHofmann's task —— View job Pull Request Review: COPT Solution Parsing Fix ✅Review SummaryThis PR correctly addresses issue #460 by adding support for COPT's Analysis DetailsChanges Made:
Review Feedback✅ Strengths
📝 Code Quality Observations
🔍 Potential Considerations
✅ Technical Correctness
🎯 RecommendationAPPROVE - This is a well-targeted fix that solves a specific solver integration issue without introducing risks. The changes are minimal, correct, and follow established patterns. Minor Suggestions for Follow-up (Optional)
The PR effectively resolves the reported issue and maintains code quality standards. Progress Checklist:
|
|
@claude actually revert the addition of "numerical" to the map. only keep the "imprecise" mapping |
|
Claude finished @FabianHofmann's task —— View job Task Completed ✅I've successfully reverted the "numerical" addition and kept only the "imprecise" mapping as requested. Changes Made
Task Progress
Commit: The PR now only includes the |
Remove 'numerical' enum value and mapping from STATUS_TO_TERMINATION_CONDITION_MAP while preserving the 'imprecise' additions for COPT solver compatibility. Co-authored-by: Fabian Hofmann <[email protected]>
|
Thanks I think that would be fine. Strangely enough, linopy does already return a solution for NUMERICAL under the current code as long as it has converged far enough. |
Add 'numerical' and 'imprecise' as proper TerminationCondition enum values and map them to SolverStatus.ok to enable solution extraction for both COPT solver statuses.
This fixes issue #460 where COPT solutions with IMPRECISE status were not being parsed, even though COPT developers confirmed solutions should be available for OK, NUMERICAL, and IMPRECISE statuses.
Generated with Claude Code