Skip to content

Conversation

@Parzival-05
Copy link

@Parzival-05 Parzival-05 commented Dec 24, 2024

Copy link
Member

@gsvgit gsvgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current configuration of F# formatter leads to ugly code.

/// <param name="stepsLimit">Number of symbolic machine steps to stop execution after. Zero value means no limit.</param>
/// <param name="aiAgentTrainingOptions">Settings for AI searcher training.</param>
/// <param name="pathToModel">Path to ONNX file with model to use in AI searcher.</param>
/// <param name="useGPU">Enables GPU processing.</param>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPU processing for what?

/// <param name="aiAgentTrainingOptions">Settings for AI searcher training.</param>
/// <param name="pathToModel">Path to ONNX file with model to use in AI searcher.</param>
/// <param name="useGPU">Enables GPU processing.</param>
/// <param name="optimize">Optimize.</param>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optimize what?

then None
elif Seq.length availableStates = 1
then Some (Seq.head availableStates)
elif Seq.length availableStates = 0 then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is really ugly style.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantomas has no way to move to the next line. Or I didn't search well.
https://fsprojects.github.io/fantomas/docs/end-users/Configuration.html#Auxiliary-settings

And yet, it seems that this style fits perfectly into the Microsoft manual: https://learn.microsoft.com/en-us/dotnet/fsharp/style-guide/formatting#multiline-bracket-formatting-styles.

elif hasTimeout then
int explorationOptions.timeout.TotalMilliseconds
/ 2
else
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What?

Some this
else None
else
None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What?

None
| _ -> None
else Some methodBase
else
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What?

@Parzival-05 Parzival-05 requested a review from gsvgit December 24, 2024 21:37
@Parzival-05 Parzival-05 force-pushed the david/gpu-support branch 2 times, most recently from b2add77 to 4147660 Compare December 27, 2024 15:20
@gsvgit
Copy link
Member

gsvgit commented Feb 21, 2025

@Parzival-05 , resolve conflicts first, please.

@Parzival-05
Copy link
Author

@Parzival-05 , resolve conflicts first, please.

rebased

@Parzival-05 Parzival-05 merged commit 6b59816 into mlSearcher Feb 26, 2025
@Parzival-05 Parzival-05 deleted the david/gpu-support branch February 26, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants