Skip to content

Conversation

@alexanderivrii
Copy link
Member

@alexanderivrii alexanderivrii commented Dec 5, 2025

Summary

Adds a new ASV benchmark for transpiling the efficient_su2(num_qubits=89) circuit into the heavy-hex graph. We already have a similar efficient_su2(num_qubits=100) benchmark, but for that VF2 can find a perfect mapping. For 89 the perfect mapping does not exist. Note that Benchpress has benchmarks for both 89 and 100 variants.

This benchmark is historically quite bad for sabre due to randomness when selecting the initial mapping, and can be used to track improvements to initial layout selection. In particular, it may be used to show value of SabrePreLayout pass (but note that this is off by default).

@alexanderivrii alexanderivrii requested a review from a team as a code owner December 5, 2025 12:52
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@alexanderivrii alexanderivrii added the type: qa Issues and PRs that relate to testing and code quality label Dec 5, 2025
@alexanderivrii alexanderivrii changed the title adding ASV utility benchmark New ASV utility benchmark Dec 5, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 19963538104

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 88.355%

Files with Coverage Reduction New Missed Lines %
crates/circuit/src/parameter/symbol_expr.rs 4 72.86%
crates/qasm2/src/lex.rs 5 90.75%
Totals Coverage Status
Change from base Build 19963174757: 0.02%
Covered Lines: 96098
Relevant Lines: 108763

💛 - Coveralls

Copy link
Member

@ShellyGarion ShellyGarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I wonder if we should add more ASV benchmarks from benchpress, but this is definitely a good addition to qiskit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: qa Issues and PRs that relate to testing and code quality

Projects

Status: Ready

Development

Successfully merging this pull request may close these issues.

4 participants