Skip to content

Improvements to tests#35

Merged
peytondmurray merged 5 commits intoQuansight:mainfrom
peytondmurray:update-tests
Jul 22, 2024
Merged

Improvements to tests#35
peytondmurray merged 5 commits intoQuansight:mainfrom
peytondmurray:update-tests

Conversation

@peytondmurray
Copy link
Collaborator

@peytondmurray peytondmurray commented Jul 16, 2024

This PR introduces a number of changes targeting dev experience:

  • Make all tests target databases named test; postgres used to target postgres_db.
  • Use ODBC Driver 18 everywhere
  • Create containers/ directory; this contains a docker-compose.yml that gets postgres (and now mssql 2022) up and running with a simple docker compose up --build, to make local testing easier
  • Removed old pyodbc pytest setup code that fiddles with sys.path. This makes things more complicated when running tests, and I've had no issue running with --import-mode=importlib
  • Added pytest setup code that checks which databases are available, and introduces some new pytest marks to facilitate skipping tests if a database service is not up and running

@peytondmurray peytondmurray merged commit 6d917e7 into Quansight:main Jul 22, 2024
@peytondmurray peytondmurray deleted the update-tests branch July 22, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant