Deduplicate module initialization#64
Merged
peytondmurray merged 11 commits intoQuansight:mainfrom Jan 28, 2026
Merged
Conversation
Collaborator
Author
|
See mkleehammer/pyodbc#1450 for upstream segfault discussion. A null-commit applied to |
ff33205 to
cfcb6e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR patches the
pyodbcmodule initialization, makingnpyodbcmodule.cppthe only place wherePyInit_<module_name>is called.Other changes
npyodbc._npyodbc. As a result of this choice, we now also run the CI tests from insidetests/directly; otherwisepytestwill add the root of the repo tosys.path(yes, even without atests/__init__.pyand with--import-mode=importlib) and thus inadvertently try to import the localnpyodbcrather than the one installed atsite-packages, causing it to fail to find the compiled extension.-Wno-write-stringscflag for Unix builds to suppress compiler warningsCloses #63.