Skip to content

Fix issue where string dtype singleton elsize was accidentally changed#71

Closed
peytondmurray wants to merge 2 commits intoQuansight:mainfrom
peytondmurray:661-singleton-dtype-fix
Closed

Fix issue where string dtype singleton elsize was accidentally changed#71
peytondmurray wants to merge 2 commits intoQuansight:mainfrom
peytondmurray:661-singleton-dtype-fix

Conversation

@peytondmurray
Copy link
Collaborator

This fixes an issue where the numpy string/bytes dtype singletons were being modified by npyodbc. This happens in 2 places:

  1. This can occur when coercing SQL types to string/bytes numpy dtypes using the target_dtypes kwarg
  2. When reading binary column types (this is the case that prompted the original bug report)

A test was also added to catch this.

@peytondmurray
Copy link
Collaborator Author

Something weird is happening with this PR. Despite pushing this branch, changes aren't being reflected here. I'll close and reopen.

@peytondmurray
Copy link
Collaborator Author

Can't reopen, apparently. Creating a new PR instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant