Fix issue where string dtype singleton elsize was accidentally changed#71
Closed
peytondmurray wants to merge 2 commits intoQuansight:mainfrom
Closed
Fix issue where string dtype singleton elsize was accidentally changed#71peytondmurray wants to merge 2 commits intoQuansight:mainfrom
peytondmurray wants to merge 2 commits intoQuansight:mainfrom
Conversation
Collaborator
Author
|
Something weird is happening with this PR. Despite pushing this branch, changes aren't being reflected here. I'll close and reopen. |
Collaborator
Author
|
Can't reopen, apparently. Creating a new PR instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the numpy string/bytes dtype singletons were being modified by npyodbc. This happens in 2 places:
target_dtypeskwargA test was also added to catch this.