Sync environment variables from the user session into systemd and dbus#257
Conversation
We're already syncing environment variables from the systemd user manager into the user session, but some variables may be set in the user session that aren't in the user manager or dbus-daemon by default. This interferes with applications that are launched by the user manager or dbus-daemon, such as Ptyxis and Kicksecure's fm-shim system. Sync environment variables from the user session into the systemd user manager and dbus-daemon to fix this. Fixes: QubesOS/qubes-issues#10759 Fixes: QubesOS/qubes-issues#10712
|
Can some test be added that covers the initial issue and the current issue:
I think it will have to be an integration test. |
|
@ben-grande Where are the integration tests stored? |
|
I never did an integration test outside of core-admin, but here is an example of pdf sanitizer using |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026043012-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026032404-devel&flavor=update
Failed tests16 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/170766#dependencies 30 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:10 performance degradations
Remaining performance tests:101 tests
|
|
Did not find an error on openqa related to this PR. |
|
Created QubesOS/qubes-core-admin#804 for the integration tests, will probably need partially re-worked before it can be merged. |
We're already syncing environment variables from the systemd user manager into the user session, but some variables may be set in the user session that aren't in the user manager or dbus-daemon by default. This interferes with applications that are launched by the user manager or dbus-daemon, such as Ptyxis and Kicksecure's fm-shim system.
Sync environment variables from the user session into the systemd user manager and dbus-daemon to fix this.
Fixes: QubesOS/qubes-issues#10759
Fixes: QubesOS/qubes-issues#10712
(Note that I haven't finished testing if this fixes the Ptyxis terminal issue, but it seems like it should. I'll report back once I've tested that.)