Add filtering to Qube Settings -> Devices Tab#437
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #437 +/- ##
==========================================
+ Coverage 69.26% 69.64% +0.37%
==========================================
Files 17 17
Lines 3943 3989 +46
==========================================
+ Hits 2731 2778 +47
+ Misses 1212 1211 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fddc370 to
ecdc732
Compare
|
@marmarta This is ready for review. The last force-Push few seconds ago should solve the few last remaining uncovered lines and coverage should be happy Here is a video preview of the patch: devices-icons.webm |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025103005-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update
Failed tests19 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/149225#dependencies 82 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:13 performance degradations
Remaining performance tests:165 tests
|
|
I really like the filtering; I'm not sold on icons, maybe they should be a bit smaller? It kind of feels cluttered. What do you think? |
|
Or maybe increase spacing between rows? |
ecdc732 to
f4cab30
Compare
|
Can you add also icons to the filters, as kind of a legend what they mean? |
Also adding device icons
f4cab30 to
937ea79
Compare
This is done |

Also adding device icons