Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Conversation

@defispartan
Copy link
Contributor

  • Update frames.js and @frames.js/debugger dependencies
  • yarn lockfile
  • Mark frame as anonymous (unless Frame explicity requires verifying Lens profileId this is recommended so that the same frame can be compatible across Lens and XMTP apps)
  • Display txn hash in completed state

Deployed test version here

Tested that it's working in frames.js debugger with clientProtocol set to None (there are some issues within the debugger with the transaction callback when signed into a clientProtocol, I think this is an issue with the debugger which I'll open an issue for)

@lusorio lusorio merged commit 366ca00 into Quidli:main Aug 2, 2024
@lusorio
Copy link
Contributor

lusorio commented Aug 2, 2024

Hey @defispartan

Thanks for the PR, it helped me understand a couple of things. However, yes, we need to validate the Lens profile. Not sure you know the Quidli frame for FC, but when creating TXs, we need to store and update them in our backend in every step, and one of the ids of the tx is the fid (for FC) and should be the profileId for Lens.

I'm watching the frames.js repo for issues, I'll keep an eye on yours.

Thanks again,

@lusorio
Copy link
Contributor

lusorio commented Aug 2, 2024

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants