Don't remap mods that are already in the target namespace #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't be running TinyRemapper to remap intermediary mods to intermediary! That's silly! This fixes that oversight. This would fix QuiltMC#482.
AlexIIL
reviewed
Dec 9, 2025
| public boolean doesModNeedRemapping(ModLoadOption mod) { | ||
| return modsToRemap.contains(mod); | ||
| public boolean modNeedsRemapping(ModLoadOption mod) { | ||
| return mod.namespaceMappingFrom() != null && !mod.namespaceMappingFrom().equals(QuiltLauncherBase.getLauncher().getMappingConfiguration().getTargetNamespace()); |
Contributor
There was a problem hiding this comment.
Why is this check duplicated? Surely we only need to check this once - that way we can rely on the list being correct everywhere that it's iterated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't be running TinyRemapper to remap intermediary mods to intermediary! That's silly! This fixes that oversight.
This would fix #482.