Fix missing padding_side=left for batch inference#1296
Open
huang7loong wants to merge 1 commit intoQwenLM:mainfrom
Open
Fix missing padding_side=left for batch inference#1296huang7loong wants to merge 1 commit intoQwenLM:mainfrom
huang7loong wants to merge 1 commit intoQwenLM:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in the Batch Inference example in README.md, where the padding_side="left" parameter was missing.
For decoder-only LLMs (e.g., GPT-style models), it's important to set padding_side to "left" during batch inference. Without this setting, the model may behave unexpectedly or generate incorrect outputs, e.g., #759
This change ensures the example runs correctly and avoids confusion for users.