fix(core): ensure global directives are always loaded (fixes #issue_2196)#2197
Closed
sushilibdev wants to merge 3 commits intoQwenLM:mainfrom
Closed
fix(core): ensure global directives are always loaded (fixes #issue_2196)#2197sushilibdev wants to merge 3 commits intoQwenLM:mainfrom
sushilibdev wants to merge 3 commits intoQwenLM:mainfrom
Conversation
…roject directives
sushilibdev
requested review from
DennisYu07,
DragonnZhang,
LaZzyMan,
Mingholy,
gwinthis,
pomelo-nwu and
tanzhenxin
as code owners
sushilibdev
changed the title
Author
|
Done! I've updated readMemoryFileContent to handle both global and project paths with proper error handling for ENOENT as suggested. Please let me know if there's anything else. Thanks! |
sushilibdev
force-pushed
the
fix/hierarchical-memory-amnesia
branch
from
717b227 to
2d52c6b
Compare
Author
|
I would like to close this Pull Request, because the issue has been resolved by the owner. |
This was referenced Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
readMemoryFileContentonly reads either global OR project directives based on a scope parameter. This causes an 'amnesia' effect where global instructions in |~/.qwen/QWEN.md` are ignored when working inside a project.Changes:
readMemoryFileContentto aggregate content from both global and project paths.Tested on Termux environment. Fixes the issue where users had to manually remind the AI of global instructions.