fix(test): handle thinking model assistant messages in SDK E2E tests#2259
Closed
wenshao wants to merge 1 commit intoQwenLM:mainfrom
Closed
fix(test): handle thinking model assistant messages in SDK E2E tests#2259wenshao wants to merge 1 commit intoQwenLM:mainfrom
wenshao wants to merge 1 commit intoQwenLM:mainfrom
Conversation
Thinking models (e.g. glm-5) emit assistant messages with only thinking blocks before sending text content. The tests incorrectly assumed every assistant message contains text blocks, causing failures. Skip thinking-only messages when checking for text content. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
wenshao
requested review from
DennisYu07,
DragonnZhang,
LaZzyMan,
Mingholy,
gwinthis,
pomelo-nwu and
tanzhenxin
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking models (e.g. glm-5) emit assistant messages with only thinking blocks before sending text content. The tests incorrectly assumed every assistant message contains text blocks, causing failures. Skip thinking-only messages when checking for text content.
TLDR
Dive Deeper
Reviewer Test Plan
Testing Matrix
Linked issues / bugs