-
Notifications
You must be signed in to change notification settings - Fork 1.9k
refactor: Refactors the VS Code file completion system to use fuzzy search #2437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1788be9
refactor(search): implement backend fuzzy search and improve file hanβ¦
qqqys ebeb7ed
refactor(completion): enhance trigger detection logic for completion β¦
qqqys 7a554b1
refactor(file-handler): improve file watcher management and cache cleβ¦
qqqys 476d6bc
test(file-handler): enhance tests for FileMessageHandler with fuzzy sβ¦
qqqys 2bd3c29
refactor(completion): enhance trigger detection logic for completion β¦
qqqys 8f5ecbc
refactor(completion): improve trigger detection logic for completion β¦
qqqys File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really like the direction here with cache invalidation on workspace changes. I think there is one lifecycle gap to watch out for: when a new workspace folder is added, we invalidate its cache entry, but we do not register a new file watcher for that folder.
That means searches in the newly added root can build a
FileSearchindex once, but later file create/change/delete events in that root will not invalidate it, so results can become stale until the provider is recreated.It may be worth creating and tracking a watcher for each newly added folder inside
onDidChangeWorkspaceFolders, so the invalidation behavior stays consistent for roots added after initialization too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. I should create a watcher for each folder. The ideal behavior would be: