fix(test): update LoadingIndicator snapshot for correct output alignment#2469
Merged
tanzhenxin merged 1 commit intoQwenLM:mainfrom Mar 19, 2026
Merged
fix(test): update LoadingIndicator snapshot for correct output alignment#2469tanzhenxin merged 1 commit intoQwenLM:mainfrom
tanzhenxin merged 1 commit intoQwenLM:mainfrom
Conversation
Contributor
📋 Review SummaryThis PR updates the LoadingIndicator snapshot test to reflect the correct text alignment with proper indentation. The change adds 2-space left padding to match the component's actual rendered output, which uses 🔍 General Feedback
🎯 Specific Feedback🔵 Low
✅ Highlights
|
tanzhenxin
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
This PR fixes the LoadingIndicator test snapshot to match the current component output format. The snapshot was outdated and needed to be updated to reflect the correct text alignment/indentation in the component rendered output.
Dive Deeper
The
LoadingIndicatorcomponent snapshot test was failing because the expected output format had changed. The snapshot now correctly captures:This is a test-only change with no modifications to the actual component logic.
Reviewer Test Plan
npm run test -- LoadingIndicator.test.tsxTesting Matrix
Linked issues / bugs
No linked issues