Skip to content

fix: preserve modalities during OpenAI logging request conversion#2473

Merged
tanzhenxin merged 1 commit intoQwenLM:mainfrom
kkhomej33-netizen:fix/openai-logging-modalities
Mar 19, 2026
Merged

fix: preserve modalities during OpenAI logging request conversion#2473
tanzhenxin merged 1 commit intoQwenLM:mainfrom
kkhomej33-netizen:fix/openai-logging-modalities

Conversation

@kkhomej33-netizen
Copy link
Copy Markdown
Contributor

Summary

  • pass resolved modalities into the OpenAI logging request converter
  • avoid replacing supported media parts with text placeholders when --openai-logging is enabled
  • add a regression test for logged multimodal request conversion

Testing

  • npm test --workspace=packages/core -- src/core/loggingContentGenerator/loggingContentGenerator.test.ts src/core/openaiContentGenerator/converter.test.ts

Copy link
Copy Markdown
Collaborator

@tanzhenxin tanzhenxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tanzhenxin tanzhenxin merged commit 0864b48 into QwenLM:main Mar 19, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants