-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: add directory/file path completion for terminal input #2879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wenshao
wants to merge
8
commits into
QwenLM:main
Choose a base branch
from
wenshao:feat/path-completion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9611029
feat: add directory/file path completion for terminal input
wenshao 8dc07ea
fix: address review feedback on path completion PR
wenshao 6add642
fix: improve path completion correctness and simplify hook
wenshao 3990b3d
test: add PATH mode handleAutocomplete test
wenshao b75f232
fix: address Copilot review feedback
wenshao ddb70ae
fix: address GPT-5.4 and Copilot review feedback
wenshao b3abb5a
fix: LRU cache set() now resets insertion order for existing keys
wenshao a7d0db5
fix: expose completionMode and support Windows C:/foo paths
wenshao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| /** | ||
| * @license | ||
| * Copyright 2025 Google LLC | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| import { describe, it, expect } from 'vitest'; | ||
|
|
||
| describe('usePathCompletion (placeholder)', () => { | ||
| // The hook uses setTimeout debounce which causes OOM in jsdom test environment. | ||
wenshao marked this conversation as resolved.
Show resolved
Hide resolved
wenshao marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| // The hook logic is verified through integration with useCommandCompletion tests | ||
| // and the underlying directoryCompletion unit tests. | ||
|
|
||
| it('isPathLikeToken recognizes path patterns', async () => { | ||
| const { isPathLikeToken } = await import('../utils/directoryCompletion.js'); | ||
| expect(isPathLikeToken('/home')).toBe(true); | ||
| expect(isPathLikeToken('./src')).toBe(true); | ||
| expect(isPathLikeToken('../lib')).toBe(true); | ||
| expect(isPathLikeToken('~/docs')).toBe(true); | ||
| expect(isPathLikeToken('hello')).toBe(false); | ||
| expect(isPathLikeToken('')).toBe(false); | ||
| // Bare tokens without separator should not trigger | ||
| expect(isPathLikeToken('~')).toBe(false); | ||
| expect(isPathLikeToken('.')).toBe(false); | ||
| expect(isPathLikeToken('..')).toBe(false); | ||
| }); | ||
|
|
||
| it('getPathCompletions returns suggestions', async () => { | ||
| const { getPathCompletions } = await import( | ||
| '../utils/directoryCompletion.js' | ||
| ); | ||
| expect(typeof getPathCompletions).toBe('function'); | ||
| }); | ||
wenshao marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }); | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.