fix(cli): prevent statusline spawn EBADF from crashing CLI (#3264)#3310
Merged
fix(cli): prevent statusline spawn EBADF from crashing CLI (#3264)#3310
Conversation
Contributor
📋 Review SummaryThis PR addresses issue #3264 by fixing a crash that occurs when 🔍 General Feedback
🎯 Specific Feedback🔵 Low
✅ Highlights
|
wenshao
force-pushed
the
fix/statusline-spawn-ebadf-crash-3264
branch
from
1f8a720 to
48ea9b2
Compare
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
wenshao
force-pushed
the
fix/statusline-spawn-ebadf-crash-3264
branch
from
48ea9b2 to
46b2223
Compare
child_process.exec() throws synchronously for spawn errors libuv does not report via the async 'error' event (EBADF, EINVAL, …). On macOS with Node 22, EBADF can surface during stdio pipe setup, and the uncaught throw escapes the debounce setTimeout callback and crashes the CLI. Wrap the exec call in try/catch so a failing statusline degrades to no output while the rest of the CLI keeps running.
wenshao
force-pushed
the
fix/statusline-spawn-ebadf-crash-3264
branch
from
46b2223 to
76e40f5
Compare
wenshao
commented
Apr 16, 2026
Collaborator
Author
wenshao
left a comment
wenshao
left a comment
There was a problem hiding this comment.
No issues found. LGTM! ✅ — gpt-5.4 via Qwen Code /review
BZ-D
reviewed
Apr 16, 2026
Collaborator
BZ-D
left a comment
BZ-D
left a comment
There was a problem hiding this comment.
Overall this is a well-scoped and well-documented fix. The try/catch placement is correct, tests cover both the crash and recovery paths, and the PR description is excellent. A few minor observations below (inline comments), but nothing blocking.
BZ-D
reviewed
Apr 16, 2026
BZ-D
reviewed
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3264.
child_process.exec()can throw synchronously for spawn errors that libuv does not report via the async'error'event. On macOS with Node 22,EBADFsurfaces fromChildProcess.spawn(during stdio pipe setup), and the uncaught throw escapes the debouncesetTimeoutcallback →uncaughtException→ CLI crashes after every assistant response whenui.statusLineis configured.Node reports a short allowlist of errors (
EACCES,EAGAIN,EMFILE,ENFILE,ENOENT,ENOSYS,EPERM) asynchronously via'error'; everything else — includingEBADF— is thrown directly fromChildProcess.prototype.spawn.This PR wraps the
exec()call inuseStatusLinewith atry/catchso a failing statusline degrades to no output while the rest of the CLI keeps running. The hook's generation counter already invalidates in-flight callbacks, so subsequent state changes recover normally.Scope and caveats
EBADFhappens on macOS Node 22 during stdio pipe setup — it may be a Node.js / libuv bug, a TTY-raw-mode race, or FD pressure from Ink's rendering. Regardless, a failing statusline command should never take the CLI down, so catching at the caller is the right layer.STATUS_LINEdebug logger, visible only withqwen -d). This matches the existing EPIPE handling a few lines below and is strictly better than crashing, but worth flagging.useStatusLineexec callsite is patched. Otherchild_process.exec/spawncall sites in the codebase may have the same sync-throw exposure — they are not audited by this PR. Happy to do a follow-up sweep if desired.ansiRegex3 is not a functionbug still exists. It's an esbuild ESM/CJS interop issue in the bundledboxen→string-width→ansi-regexchain that fires from the error renderer. This PR prevents the path that was reaching it, so the symptom is gone, but the underlying bundling bug remains latent and will resurface for any other unhandled error that reachesboxen. Worth tracking in a separate issue.Changes
packages/cli/src/ui/hooks/useStatusLine.ts— wrapexec()intry/catch; on failure log to theSTATUS_LINEdebug logger, clear output, and return. Generation counter andactiveChildRefalready handle recovery on the next state change.packages/cli/src/ui/hooks/useStatusLine.test.ts— two new tests: (1) synchronousEBADFthrow does not crash the hook, (2) subsequent state changes recover and re-execute successfully (verifies no wedged refs).Test plan
npx vitest run packages/cli/src/ui/hooks/useStatusLine.test.ts— 32/32 passnpx vitest run packages/cli/src/ui/hooks/— 635/635 pass (no regressions in neighbor hooks)npx tsc --noEmit -p packages/cli/tsconfig.json— cleannpx eslinton modified files — cleanui.statusLineconfigured (requires a macOS environment; reporter's repro steps in ui.statusLine crashes CLI with spawn EBADF on macOS, then hits ansiRegex3 is not a function #3264 can be used)