Fix Undefined behavior from signed bit shifts#337
Closed
rocm-devops wants to merge 7 commits intoamd-stagingfrom
Closed
Fix Undefined behavior from signed bit shifts#337rocm-devops wants to merge 7 commits intoamd-stagingfrom
rocm-devops wants to merge 7 commits intoamd-stagingfrom
Conversation
Bit shift operations on signed numbers should not shift into or beyond the signed bit as this results in Undefined Behaviour. Signed-off-by: Sunday Clement <Sunday.Clement@amd.com>
Bit Shifting an unsigned integer is undefined behavior. BUG: SWDEV-532853 Signed-off-by: Sunday Clement <Sunday.Clement@amd.com>
Bit shifting signed integers into or beyond the sign bit is undefined. Signed-off-by: Sunday Clement <Sunday.Clement@amd.com>
Changing the signed integers in the macro expressions throughout the file to avoid overflow. Signed-off-by: Sunday Clement <Sunday.Clement@amd.com>
|
Imported to rocm-systems |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.