Closed
Conversation
The wrong variable is used in the assertion statement, should be error checking for the value of paramEndLoc after it is modified by the call to find(). Signed-off-by: Sunday Clement <Sunday.Clement@amd.com>
In the event that the SvmProfileControl destructor is called and event == -1 is true then the call to close(event) is effectively close(-1) which is undefined behaviour. This has been changed to only call close() on valid file descriptors. Signed-off-by: Sunday Clement <Sunday.Clement@amd.com>
In the case that there is an incomplete read the call to copyTo() will now return an error. Signed-off-by: Sunday Clement <Sunday.Clement@amd.com>
Destructors are implicitly marked with noexcept being true by default so if its not explicitly marked false in the destructor or the functions it calls, any thrown exceptions will cause the program to crash. Signed-off-by: Sunday Clement <Sunday.Clement@amd.com>
Author
|
!retry |
|
Imported to rocm-systems |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.