Skip to content

Deduplicate test_sanity_check.yml into test_component.yml#3868

Merged
jayhawk-commits merged 1 commit intomainfrom
users/jayhawk-commits/deduplicate-sanity-check
Mar 11, 2026
Merged

Deduplicate test_sanity_check.yml into test_component.yml#3868
jayhawk-commits merged 1 commit intomainfrom
users/jayhawk-commits/deduplicate-sanity-check

Conversation

@jayhawk-commits
Copy link
Contributor

@jayhawk-commits jayhawk-commits commented Mar 10, 2026

Implementation for #3823

Summary

  • Adds a "sanity" entry to the test matrix in fetch_test_configurations.py, producing a separate sanity_component GHA output that flows through the same loop logic as other components.
  • Adds build_tools/github_actions/test_executable_scripts/test_sanity.py to encapsulate the sanity test logic (previously inline in the workflow).
  • Updates test_artifacts.yml to call test_component.yml for the sanity gate via the new sanity_component output.
  • Deletes the now-redundant test_sanity_check.yml.

The existing workflow_dispatch + sanity_check_only_for_family input on test_artifacts.yml already covers the dispatch use case, so no workflow_dispatch trigger was added to test_component.yml.
This effort will be leveraged on the super-repos, to let them run the new sanity test script.

Test plan

  • Verify CI sanity gate passes on this PR.
  • Confirm test_artifacts.yml sanity job runs via test_component.yml with correct container options (--cap-add SYS_MODULE -v /lib/modules:/lib/modules).
  • Confirm Windows sanity path (PATH/HIP_CLANG_PATH) is set correctly in test_sanity.py.

Add a "sanity" entry to the test matrix in fetch_test_configurations.py
and a test_sanity.py script, then route sanity through test_component.yml
via a new sanity_component output in test_artifacts.yml. Delete the now-
redundant test_sanity_check.yml. The existing workflow_dispatch +
sanity_check_only_for_family input on test_artifacts.yml covers the
dispatch use case.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copy link
Contributor

@ammallya ammallya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jayhawk-commits jayhawk-commits merged commit 0478f9e into main Mar 11, 2026
335 of 343 checks passed
@jayhawk-commits jayhawk-commits deleted the users/jayhawk-commits/deduplicate-sanity-check branch March 11, 2026 15:24
@github-project-automation github-project-automation bot moved this from TODO to Done in TheRock Triage Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants