Skip to content

Ionic new 950 1128#119

Merged
zhangfei829 merged 40 commits intomainfrom
ionic_new_950_1128
Dec 16, 2025
Merged

Ionic new 950 1128#119
zhangfei829 merged 40 commits intomainfrom
ionic_new_950_1128

Conversation

@zhangfei829
Copy link
Collaborator

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

zhangfei829 and others added 30 commits November 13, 2025 18:06
Signed-off-by: zhangfei829 <328415201@qq.com>
Signed-off-by: zhangfei829 <328415201@qq.com>
Signed-off-by: zhangfei829 <328415201@qq.com>
Signed-off-by: Zhang <fizhang@amd.com>
Signed-off-by: Zhang <fizhang@amd.com>
Signed-off-by: zhangfei829 <328415201@qq.com>
Signed-off-by: zhangfei829 <328415201@qq.com>
Signed-off-by: zhangfei829 <328415201@qq.com>
Signed-off-by: Zhang <fizhang@amd.com>
Signed-off-by: Zhang <fizhang@amd.com>
Signed-off-by: Zhang <fizhang@amd.com>
Comment on lines +440 to +450
// Get gid
union ibv_gid ibvGid;
ret = ibv_query_gid(context, config.portId, /*config.gidIdx */1, &ibvGid);
assert(!ret);
memcpy(endpoint.handle.eth.gid, ibvGid.raw, sizeof(endpoint.handle.eth.gid));
#if 0
for (int i = 0; i< 16; i++) {
printf("%02x", endpoint.handle.eth.gid[i]);
}
printf("\n");
#endif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use AutoSelectGidIndex() to automatically identify the gid (refer to other providers),
Also, don't forget to modify sgid_index.

}
#else
template <>
inline __device__ int PollCq<ProviderType::PSD>(WorkQueueHandle& wqHandle, CompletionQueueHandle& cqHandle,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the usage of wqHandle can be placed within the quiet function of mori-shmem to maintain consistency. pollCq only needs to check the consIdx position of the cq.
Perhaps we can refactor this part later.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussion, we plan to make improvements and optimizations to this point in the future.

@jhchouuu
Copy link
Collaborator

And I used the compilation switch USE_BNXT=ON for brcm, which caused the compilation of ionic.cpp to fail. I think this is a compatibility issue.

@isytwu isytwu force-pushed the ionic_new_950_1128 branch from 5b3466c to 98c1c4c Compare December 15, 2025 13:15
Signed-off-by: zhangfei829 <328415201@qq.com>
@jhchouuu
Copy link
Collaborator

After test on bnxt branch, I can complete the compilation and testing.
LGTM. I think we can merge.

@zhangfei829 zhangfei829 merged commit 6b5a1e5 into main Dec 16, 2025
4 checks passed
TianDi101 pushed a commit that referenced this pull request Jan 12, 2026
support ionic&multi-qp&FP8_E4M3FN and fix some ep issues
TianDi101 pushed a commit that referenced this pull request Jan 12, 2026
support ionic&multi-qp&FP8_E4M3FN and fix some ep issues
TianDi101 pushed a commit that referenced this pull request Jan 28, 2026
support ionic&multi-qp&FP8_E4M3FN and fix some ep issues
TianDi101 pushed a commit that referenced this pull request Feb 5, 2026
support ionic&multi-qp&FP8_E4M3FN and fix some ep issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants