[ROCM-20039] Fix AttributeError for gpureset on VMs#3925
Open
[ROCM-20039] Fix AttributeError for gpureset on VMs#3925
Conversation
Argument gpureset is not registered by the parser on VMs, so accessing args.gpureset directly raises AttributeError. Normalize it to False when not available. Signed-off-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com>
db5f651 to
82341e1
Compare
gabrpham
approved these changes
Mar 10, 2026
Contributor
gabrpham
left a comment
There was a problem hiding this comment.
Looks good to me. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Argument gpureset is not registered by the parser on VMs, so accessing args.gpureset directly raises AttributeError. Normalize it to False when not available.
JIRA ID
ROCM-20039
Test Plan
amd-smi reset -l on VM
Test Result
On VM:

Submission Checklist