Skip to content

Fetch autonomy stack last update automatically#93

Merged
mrpollo merged 7 commits intoROS-Aerial:mainfrom
natmol:feature/fetch-autonomy-stack-last-update-automatically
May 2, 2025
Merged

Fetch autonomy stack last update automatically#93
mrpollo merged 7 commits intoROS-Aerial:mainfrom
natmol:feature/fetch-autonomy-stack-last-update-automatically

Conversation

@natmol
Copy link
Contributor

@natmol natmol commented Apr 22, 2025

  • Adds a script to automatically update the "Last update date" entry of the Autonomy stacks
  • Includes a workflow to run the script every day at 1 am and push the changes

@natmol natmol marked this pull request as draft April 22, 2025 15:54
@natmol natmol marked this pull request as ready for review April 22, 2025 15:54
@natmol natmol changed the title Feature/fetch autonomy stack last update automatically Fetch autonomy stack last update automatically Apr 22, 2025
@knmcguire
Copy link
Member

knmcguire commented Apr 25, 2025

Ah nice! We are kind of also discussing if we want to change up the format of the aerial robotics landscape a bit to not include too much data and have a seperate best-of list (see this issue #90), but that is still up in the air. So I think we could merge this and we might change it up with inspiration from you script if necessary

@TOTON95 what do you think of this?

@mrpollo Seems like the PR review deployment fails, probably just an server error but perhaps you can take a quick look

@TOTON95
Copy link
Contributor

TOTON95 commented Apr 26, 2025

@natmol This looks good, thank you! This will help a lot.

@knmcguire We can certainly use it as a solid starting point, and shape it accordingly to two questions:

  1. Should we keep the fetch workflow isolated from the build, or perform a periodical build while fetching the latest commit dates?
  2. (Kinda dependent on the first question) Should the update_repo_dates.py script be executed by the workflow, or by using the pre-build scripts used in mkdocs?

@knmcguire
Copy link
Member

Good question. I think perhaps that a monthly fetch that is separate from the build might be a better idea here. Ofcourse updating it once a year is too long, but I don't thing we should do it with every change either.

for number 2... I don't think I have a preference for this, but if we want to keep it seperate from the build then it should just be a seperate script.

@TOTON95
Copy link
Contributor

TOTON95 commented May 1, 2025

@knmcguire Sure, a monthly or bi-weekly build could be enough for this purpose. And yes, we can keep the script away from mkdocs.

@mrpollo
Copy link
Contributor

mrpollo commented May 1, 2025

@knmcguire unfurtunately there are security implications when allowing previews from forks, perhaps we should disable this action if the base is remote.

See rossjrw/pr-preview-action#6

Copy link
Contributor

@mrpollo mrpollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments

natmol and others added 2 commits May 2, 2025 17:42
Co-authored-by: Ramon Roche <mrpollo@gmail.com>
@natmol natmol requested a review from mrpollo May 2, 2025 16:19
Copy link
Contributor

@mrpollo mrpollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@mrpollo mrpollo merged commit 3892091 into ROS-Aerial:main May 2, 2025
1 check failed
@mrpollo
Copy link
Contributor

mrpollo commented May 2, 2025

Thanks for the contribution @natmol 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants