fixed klayout tech files and DRC deck#304
Open
marwaneltoukhy wants to merge 2 commits intoRTimothyEdwards:masterfrom
Open
fixed klayout tech files and DRC deck#304marwaneltoukhy wants to merge 2 commits intoRTimothyEdwards:masterfrom
marwaneltoukhy wants to merge 2 commits intoRTimothyEdwards:masterfrom
Conversation
RTimothyEdwards
requested changes
Nov 2, 2022
Owner
RTimothyEdwards
left a comment
There was a problem hiding this comment.
But I'm already installing the sky130_mr.drc file from precheck, so that it's not necessary to maintain a redundant copy of the file in open_pdks. Are you using the file installed in, e.g., libs.tech/klayout/drc/sky130A_mr.drc?
Owner
RTimothyEdwards
left a comment
There was a problem hiding this comment.
Plus your changes to the sky130.lyp file look like the changes that are already in, e.g., libs.tech/klayout/tech/sky130A.lyp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added correct tech files for klayout
Added DRC deck that is used in precheck to tapeout caravel