Skip to content

Comments

WebSite part multiple password delete#13

Open
EvoWebFrance wants to merge 8 commits intoRabbit-Company:mainfrom
EvoWebFrance:main
Open

WebSite part multiple password delete#13
EvoWebFrance wants to merge 8 commits intoRabbit-Company:mainfrom
EvoWebFrance:main

Conversation

@EvoWebFrance
Copy link

@EvoWebFrance EvoWebFrance commented Jul 2, 2023

Can't push to the website part, the server part have been already pushed....

@zigazajc007
Copy link
Member

Hello,

Thanks for your contribution.

I also wanted to add support for multi-password deletion, but the problem is the design.
Checkbox and the button doesn't look good.

Maybe we can try it something like that:

  • User will hold down the row that he wants to select for at least 2 seconds.
  • After 2 seconds of holding down, the row will get selected (The background color of the row will also change to more lighter one - This will indicate that this row has been selected)
  • If at least 1 row is already selected, then each new row can be selected just by clicking on it.
  • Only after at least 1 row has been selected, the "Delete passwords" button will appear at the bottom and the buttons for pages will disappear.
  • When no rows are selected the "Delete passwords" button will disappear and the pages buttons reaper.
  • When you click outside of table, all selected rows will get deselected.

@EvoWebFrance
Copy link
Author

Hello, that's a good Idea.
I will remove the checkboxes and make this kind of UI. No need to change anything on server side.
I have pushed my modifications on my fork, but how should push on the website repo ?

Regards.

@zigazajc007
Copy link
Member

Hello,

You can continue working on your fork of the repository -> main branch.
So I can also help you with implementing this feature.

@EvoWebFrance
Copy link
Author

Hello, I have pushed the first version of the new UI on my fork. It works good, you can check it.
Perhaps an indicator when select mode is on should be fired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants