Narrow the bar display by another couple of characters #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Ironically the wysiwig editor makes the two lines identical and I spent an extra ten minutes trying to figure out if I'd screwed up my rebase or was fat fingering the clipboard commands. It's only the monospaced layout where they are discernible. Fucking kerning, man. |
… ANSI line drawing. test 1 ▏█████████████████████████▕ 125,555,696 ops/sec | 11 samples By using a left and right justified equivalent of "|" there's enough space to distinguish the bar from the end braces. These still look reasonable pasted into Github issue comments (which was the problem with one of my earlier attempts to make the bar display narrower). Since the important info in the chart output is at the right end of the line, this is what will probably be the last in my edits to try to shift the punchline of the output as far left as is possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By leveraging a bit more ANSI block character trickery.
Before and after:
I've previously posted two other PRs with a similar motive: The right hand side of the chart output is more actionable than the left. Therefore anything I can do to shift this farther left so that clipping or line wrapping doesn't tank your ability to scan for problems, is worth doing.
This is probably the last such improvement that can be made. The column widths can already be adjusted, and this is the last of the whitespace that is likely worth touching, with the possible exception of "120,782,882 ops/sec" -> "120,782,882/sec".