Uses same x data for reflectivity and sld curves and shaded plots #249
Conversation
StephenNneji
left a comment
StephenNneji
left a comment
There was a problem hiding this comment.
Looks good to me, please see comments. @arwelHughes can we get your thoughts on this before its merged
|
|
||
| % 2. Reflectivity and SLD shading | ||
| predInts = refPercentileConfidenceIntervals(bayesOutputs,problemStruct,problemCells,problemLimits,controls); | ||
| predInts = refPercentileConfidenceIntervals(bayesOutputs,problemStruct,problemCells,problemLimits,controls,result.reflectivity,result.sldProfiles); |
There was a problem hiding this comment.
Why not pass in results then do refXVals{i} = result.reflectivity{i}(:,1)';
There was a problem hiding this comment.
Yes, good call.
|
Hi @arwelHughes, this PR addresses the bug in shaded plots where the x range of the reflectivity and sld can differ for the plotted lines and the shaded regions. The cause of this is that the x range of the shaded region is arbitrarily chosen from the x range for the first row of the chain in "refPercentileConfidenceIntervals". I've changed this to instead have the x range set to that of the reflectivity and SLD already calculated in "processBayes.m" from the best param values. This means the x ranges for the lines and shaded regions match, and therefore "reflectivtyXData" and "sldXData" can be removed from the "bayesResults" struct. Before and after images are below:
|
DrPaulSharp
force-pushed
the
predictions
branch
2 times, most recently
from
8a30f5c to
13ee383
Compare
DrPaulSharp
force-pushed
the
predictions
branch
from
13ee383 to
ca641b2
Compare
2 participants
No description provided.