Skip to content

Adds docstring for parameter class and some refactors#358

Merged
StephenNneji merged 7 commits intoRascalSoftware:masterfrom
StephenNneji:docs_parameter_class
Mar 6, 2025
Merged

Adds docstring for parameter class and some refactors#358
StephenNneji merged 7 commits intoRascalSoftware:masterfrom
StephenNneji:docs_parameter_class

Conversation

@StephenNneji
Copy link
Collaborator

@StephenNneji StephenNneji commented Mar 4, 2025

Refactors the projectClass to reduces the number of lines in the file. Breaks out the parameter methods in the file into a mixin class. Removes non-keyword set method such as setParameterValue to unify with other properties like Bulk-in.

@StephenNneji StephenNneji force-pushed the docs_parameter_class branch from 7fa8bf8 to 39b0b8c Compare March 5, 2025 16:09
@StephenNneji StephenNneji requested a review from DrPaulSharp March 5, 2025 17:15
Copy link
Collaborator

@DrPaulSharp DrPaulSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, just a bit of tidying up to do.

Also, is there any point in retaining the setValues, setLimits, etc methods in parametersClass since they're not called and we don't recommend using them?

@StephenNneji
Copy link
Collaborator Author

This looks great, just a bit of tidying up to do.

Also, is there any point in retaining the setValues, setLimits, etc methods in parametersClass since they're not called and we don't recommend using them?

I will leave them in as non-keyword alternatives for making changes in the parametersClass, as long as the user is willing to do problem.parameters.setValue() I don't mind what I am against is cloning every method of the parametersClass in the projectClass

@StephenNneji StephenNneji requested a review from DrPaulSharp March 6, 2025 15:13
Copy link
Collaborator

@DrPaulSharp DrPaulSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just some mu and sigma comments to update.

@StephenNneji StephenNneji force-pushed the docs_parameter_class branch from 402363b to 02605b6 Compare March 6, 2025 17:04
@StephenNneji StephenNneji merged commit bb087ae into RascalSoftware:master Mar 6, 2025
5 checks passed
@StephenNneji StephenNneji deleted the docs_parameter_class branch September 3, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants