-
Notifications
You must be signed in to change notification settings - Fork 4
Adds examples #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds examples #36
Conversation
| RAT.utils.plotting.plot_ref_sld(project, results) | ||
|
|
||
| # C++ | ||
| project.custom_files.set_fields(0, filename='custom_bilayer.dll', language='cpp') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I change the filename to customBilayer.dll the function does not update it is still custom_bilayer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you'll need to recompile. I'll add the README.md from the matlab which contains the compilation instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The compilation instructions are in the docs, no need to copy them over. What I am taking about is on the Matlab side if I do
problem.addCustomFile('DSPC Model','customBilayer.m','matlab',pwd);
The function is set to customBilayer but then if I do
problem.setCustomFile(1,'filename', 'custom_bilayer.py', 'path', path);
the function is set to 'custom_bilayer' unless I explicitly specified a function name
On the python side, the function stays the same after the filename is changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I've set it up to have the function name mapped to the filename for matlab, and free otherwise. Let me know what you think of this behaviour.
StephenNneji
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job, Thanks for your hard work on this one amidst the confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an __init__.py file to this folder also, otherwise it won't be copied when the user installs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the "tests/test_data" directory need one as well then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed, at the moment, we don't copy tests for install
No description provided.