Adds conversion between R1 .mat files and Python Projects#55
Merged
alexhroom merged 15 commits intoRascalSoftware:mainfrom Aug 9, 2024
alexhroom:46-read-r1-matlab
Merged
Adds conversion between R1 .mat files and Python Projects#55alexhroom merged 15 commits intoRascalSoftware:mainfrom alexhroom:46-read-r1-matlab
Projects#55alexhroom merged 15 commits intoRascalSoftware:mainfrom
alexhroom:46-read-r1-matlab
Conversation
41 tasks
DrPaulSharp
reviewed
Aug 7, 2024
Collaborator
DrPaulSharp
left a comment
There was a problem hiding this comment.
This is looking good, alongside the specific comments:
- Please make a python script to go alongside the jupyter notebook for the example.
- Have a look at the matlab example and see what you can incorporate from it into the python script and notebook.
- See if you can test the save to matlab - take a look at tests in "test_inputs" and "test_wrappers" to see if you can write somethimg similar.
DrPaulSharp
reviewed
Aug 8, 2024
Collaborator
DrPaulSharp
left a comment
There was a problem hiding this comment.
See specific comments
DrPaulSharp
reviewed
Aug 9, 2024
DrPaulSharp
approved these changes
Aug 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46 by adding functions
r1_to_project_classandproject_class_to_r1, which convert between R1 .mat files and PythonProjects.