Skip to content

Adds conversion between R1 .mat files and Python Projects#55

Merged
alexhroom merged 15 commits intoRascalSoftware:mainfrom
alexhroom:46-read-r1-matlab
Aug 9, 2024
Merged

Adds conversion between R1 .mat files and Python Projects#55
alexhroom merged 15 commits intoRascalSoftware:mainfrom
alexhroom:46-read-r1-matlab

Conversation

@alexhroom
Copy link
Collaborator

Fixes #46 by adding functions r1_to_project_class and project_class_to_r1, which convert between R1 .mat files and Python Projects.

Copy link
Collaborator

@DrPaulSharp DrPaulSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, alongside the specific comments:

  • Please make a python script to go alongside the jupyter notebook for the example.
  • Have a look at the matlab example and see what you can incorporate from it into the python script and notebook.
  • See if you can test the save to matlab - take a look at tests in "test_inputs" and "test_wrappers" to see if you can write somethimg similar.

@alexhroom alexhroom requested a review from DrPaulSharp August 8, 2024 10:56
Copy link
Collaborator

@DrPaulSharp DrPaulSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See specific comments

@alexhroom alexhroom requested a review from DrPaulSharp August 9, 2024 10:29
Copy link
Collaborator

@DrPaulSharp DrPaulSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the specific comment, plus also please make the new example importable by adding an __init__.py to the convert_rascal_project directory and adding this example to the __init__.py in the examples directory.

@alexhroom alexhroom merged commit 730fe29 into RascalSoftware:main Aug 9, 2024
@alexhroom alexhroom deleted the 46-read-r1-matlab branch August 9, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Read in RASCAL1 and RAT input files

2 participants