Conversation
joanise
force-pushed
the
dev.ej/py313
branch
from
21a567f to
198b3f9
Compare
joanise
force-pushed
the
dev.ej/py313
branch
from
198b3f9 to
5a5efac
Compare
Member
Author
|
@dhdaines I've tested this to my satisfaction now, the workflow builds the wheels for 3.8..3.13 inclusively for the three OSs. I can install the win py3.13 wheel on my Windows machine and get ReadAlong Studio's test suite to pass (with some other changes I'll have to PR for that project to support 3.13 too). |
Member
Author
|
Once this is merged, I would like to release 0.6.5 |
dhdaines
approved these changes
Nov 22, 2024
Contributor
dhdaines
left a comment
dhdaines
left a comment
There was a problem hiding this comment.
Looks great! Sorry it took me weeks to get around to approving such a simple PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
Create wheels for Python 3.13
Fixes?
Make it easier to install in Windows for Python 3.13
Feedback sought?
Sanity check
Priority?
medium
Tests added?
tested manually, works fine on my machine, will dispatch build_wheel to make sure that works too
How to test?
Run the CI workflow
build_wheels.ymlConfidence?
medium, will be high once I'm done testing
Version change?
yes, will need patch bump to publish py313 wheels.